Fortress Forever

Go Back   Fortress Forever > Community > General Discussion

Closed Thread
 
Thread Tools Display Modes
Old 10-07-2018, 02:28 AM   #2101
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
squeek502 commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
I'm not really seeing how #327 was happening in the first place. It looks like the previous code was essentially, "if an SG is sabotaged, anyone can damage it," and [`IsSabotaged()` is a prereq of...
View on Github
FF_Team is offline  


Old 10-07-2018, 03:11 AM   #2102
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
It definitely exists (just sab a SG then shoot it), thats what i was trying to address. I assumed the sabotage properties would always be set on the buildable base class, which is not true, I think. I will re-test
View on Github
FF_Team is offline  


Old 10-07-2018, 03:19 AM   #2103
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
squeek502 commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
Where does FCanTakeDamage return false in that instance (when trying to damage your maliciously sabotaged SG)? Or is it something else that's affecting things?
View on Github
FF_Team is offline  


Old 10-07-2018, 08:03 PM   #2104
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
The previous code always returned true if it was sabotaged, is that what you are asking?
View on Github
FF_Team is offline  


Old 10-08-2018, 12:32 AM   #2105
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
squeek502 commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
Yeah, but if that's true, shouldn't it be impossible for there to be a bug where a (maliciously) sabotaged SG couldn't be damaged? Maybe I'm misunderstanding what #327 is saying?
View on Github
FF_Team is offline  


Old 10-09-2018, 02:17 AM   #2106
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
Indeed, it's saying it could be damaged by the sabotuer which arguably doesn't make sense when friendly fire is on. this really comes down to a gameplay decision:

do sabotaged buildings 'belong' to the sabotaging team? I would not be surprised if the original devs intentionally made them...
View on Github
FF_Team is offline  


Old 10-11-2018, 02:02 AM   #2107
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
squeek502 commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
Ohhh, ok I get it. The spy can damage the gun they have maliciously sabotaged when FF is off. The title of #327 is super confusing.
View on Github
FF_Team is offline  


Old 10-13-2018, 06:53 PM   #2108
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
True that! I'm traveling and will finish this up after next week
View on Github
FF_Team is offline  


Old 11-01-2018, 04:37 AM   #2109
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
I debugged through this, didnt understand how sabotaging works - `m_hSaboteur` is always set so disregard that. I will refactor the duplicated sentry/dispenser stuff then this should be good to go
View on Github
FF_Team is offline  


Old 11-01-2018, 05:01 AM   #2110
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem synchronized pull request fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting')

View on Github
FF_Team is offline  


Old 11-01-2018, 05:02 AM   #2111
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem synchronized pull request fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting')

View on Github
FF_Team is offline  


Old 11-01-2018, 05:05 AM   #2112
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem commented on issue fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting'):
just tested it , works more gooder. also learned you can safely pass NULL to dynamic cast, so i'm just doing that to check it's a buildable
View on Github
FF_Team is offline  


Old 11-01-2018, 08:50 PM   #2113
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem merged pull request fortressforever/fortressforever#362 ('add more debug instructions to README') from DexterHaslem to beta

View on Github
FF_Team is offline  


Old 11-01-2018, 08:50 PM   #2114
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem pushed 2 commits to fortressforever/fortressforever:beta

  • c45f8c DexterHaslem: 'update the debugging section of readme, add instructions for running directly from VC++'
  • 94517d DexterHaslem: 'Merge pull request #362 from DexterHaslem/fluff/add-debug-info-readme. add more debug instructions...'

View on Github
FF_Team is offline  


Old 11-01-2018, 08:51 PM   #2115
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem closed issue fortressforever/fortressforever#327 ('Sabotaging spy (and their team) can damage own sabotaged SG if friendly fire is off')

View on Github
FF_Team is offline  


Old 11-01-2018, 08:51 PM   #2116
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem merged pull request fortressforever/fortressforever#363 ('Makes sabotaged things respect friendly fire setting') from DexterHaslem to beta

View on Github
FF_Team is offline  


Old 11-01-2018, 08:51 PM   #2117
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem pushed 5 commits to fortressforever/fortressforever:beta

  • 1290b8 DexterHaslem: 'make sabotaged sentries behave with friendly fire. fixes #327'
  • d2ea35 DexterHaslem: 'make dispenser det damage behave with friendly fire'
  • 88bde0 DexterHaslem: 'refactor buildable dmg checks to base buildable class. rip copy pasta'
  • e77698 DexterHaslem: 'use GetBool for cvar'
  • 8d6fcd DexterHaslem: 'Merge pull request #363 from DexterHaslem/fix-ff-sabotaged-buidables. Makes sabotaged things...'

View on Github
FF_Team is offline  


Old 11-01-2018, 08:51 PM   #2118
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
DexterHaslem closed issue fortressforever/fortressforever#273 ('Maliciously sabotaged SG explosion damage can kill teammates when friendlyfire is off')

View on Github
FF_Team is offline  


Old 11-02-2018, 01:18 AM   #2119
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
squeek502 merged pull request fortressforever/fortressforever#361 ('Remove the -1 frag for dying from the world') from squeek502 to beta

View on Github
FF_Team is offline  


Old 11-02-2018, 01:18 AM   #2120
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 66 Times
squeek502 pushed 1 commit to fortressforever/fortressforever:beta

  • d16d78 squeek502: 'Remove the -1 frag for dying from the world (#361). This -1 was already removed for suicides, so it...'

View on Github
FF_Team is offline  


Closed Thread


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 11:31 PM.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2018, vBulletin Solutions, Inc.