Fortress Forever

Go Back   Fortress Forever > Community > General Discussion

Closed Thread
 
Thread Tools Display Modes
Old 12-09-2014, 10:25 PM   #21
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
ddm999 closed issue fortressforever/fortressforever#92 ('With require() replacing IncludeScript(), included files are not logged.')

View on Github
FF_Team is offline  


Old 12-09-2014, 10:25 PM   #22
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
ddm999 commented on issue fortressforever/fortressforever#92 ('With require() replacing IncludeScript(), included files are not logged.'): 'Fair enough.. (Also I had no idea those were actually posted because the script behind GitHub...'

View on Github
FF_Team is offline  


Old 12-09-2014, 10:29 PM   #23
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
FDA- commented on issue fortressforever/fortressforever#93 ('Make weapon slots consistent (3 weapon system revisited)'): 'I agree with Aftershock about demo on all points. I also would like to see the spy keep his nail...'

View on Github
FF_Team is offline  


Old 12-09-2014, 10:43 PM   #24
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
ddm999 commented on issue fortressforever/fortressforever#93 ('Make weapon slots consistent (3 weapon system revisited)'): 'I agree with FDA on this. Making it have 3 weapon slots for all classes just hides away parts from...'

View on Github
FF_Team is offline  


Old 12-09-2014, 10:54 PM   #25
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
ddm999 opened issue fortressforever/fortressforever#94 ('Modify the map guide options on team select.')

View on Github
FF_Team is offline  


Old 12-09-2014, 10:56 PM   #26
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
squeek502 commented on issue fortressforever/fortressforever#93 ('Make weapon slots consistent (3 weapon system revisited)'): '@FDA-:. > The idea sounds very clunky, and could confuse players into thinking "hold click to...'

View on Github
FF_Team is offline  


Old 12-09-2014, 10:58 PM   #27
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
squeek502 commented on issue fortressforever/fortressforever#94 ('Modify the map guide options on team select.'): 'Makes sense.'

View on Github
FF_Team is offline  


Old 12-09-2014, 11:53 PM   #28
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
FDA- commented on issue fortressforever/fortressforever#93 ('Make weapon slots consistent (3 weapon system revisited)'): '" Should he stand back and kill an SG from far away or should he use his unique abilities to get...'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:42 AM   #29
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on issue fortressforever/fortressforever#90 ('Default hud_fastswitch to 1 and add hud_weaponselect cvar'): 'Sounds like a great compromise. :+1: '

View on Github
FF_Team is offline  


Old 12-10-2014, 12:42 AM   #30
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#89@e9c4db ('Fixed CFFCrosshairOptions::UpdateSliders assert and did some cleanup'): 'this iCurrentWeapon is a bit confusing now - is this actually currentCrosshair ?'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:43 AM   #31
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on issue fortressforever/fortressforever#89 ('Fixed CFFCrosshairOptions::UpdateSliders assert and did some cleanup'): 'Minor suggestion otherwise all good :+1: '

View on Github
FF_Team is offline  


Old 12-10-2014, 12:45 AM   #32
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#88@ea856b ('Generate <classname>.cfg/userconfig.cfg files at runtime if they don't exist'): 'whats MOD here?'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:48 AM   #33
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#88@ea856b ('Generate <classname>.cfg/userconfig.cfg files at runtime if they don't exist'): 'whats "rb"?'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:51 AM   #34
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#88@ea856b ('Generate <classname>.cfg/userconfig.cfg files at runtime if they don't exist'): 'This whole loop could do with a bit more readability help. Hungarian prefixes hurt when it gets to...'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:52 AM   #35
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#88@ea856b ('Generate <classname>.cfg/userconfig.cfg files at runtime if they don't exist'): 'I think you can invert this "if" statement and just return early if the file doesnt exist, reduces...'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:52 AM   #36
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#88@ea856b ('Generate <classname>.cfg/userconfig.cfg files at runtime if they don't exist'): 'Again you could return early here and invert the if statement, reduces nesting'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:54 AM   #37
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on issue fortressforever/fortressforever#88 ('Generate <classname>.cfg/userconfig.cfg files at runtime if they don't exist'): 'This is generally a good idea. The code could do with a slight cleanup but otherwise all good :+1: '

View on Github
FF_Team is offline  


Old 12-10-2014, 12:57 AM   #38
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on issue fortressforever/fortressforever#85 ('Scout movement weapon'): 'The only other thing we werent quite happy with, design mechanics wise, (if I remember correctly,...'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:58 AM   #39
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#85@c9bfd4 ('Scout movement weapon'): 'i suspect we don't need both?'

View on Github
FF_Team is offline  


Old 12-10-2014, 12:59 AM   #40
FF_Team
Fortress Forever Staff
 
FF_Team's Avatar
 
Join Date: Nov 1999
Posts Rated Helpful 61 Times
AfterShockFF commented on the diff of pull request fortressforever/fortressforever#85@c9bfd4 ('Scout movement weapon'): 'We should probably try to get rid of these useless comments on new files, at least we should try to...'

View on Github
FF_Team is offline  


Closed Thread


Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 08:55 AM.


Powered by vBulletin® Version 3.8.7
Copyright ©2000 - 2017, vBulletin Solutions, Inc.